fix: fix incorrect handling of contract_address as an array #483
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Please understand we are hesitant in merging a one-liner from an unknown contributor. You can have a look at the issues for a list of know bugs which need fixing. For anything else, we would prefer if you could open an issue first before proposing a fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
I noticed that
contract_addresswas being treated as an array in the code, which caused an issue when trying to accesscontract_address[0].Since
contract_addressis actually a string, I've updated the code to correctly check its truthiness.The fix ensures the test works as intended.
This change resolves the issue and aligns with the expected data type.
Does this introduce a breaking change?
no
Other information